Conversation
briangow
force-pushed
the
bg_fix_gain_formula
branch
from
66f7411 to
4cc0267
Compare
Member
|
@briangow could you add a test for this? |
briangow
force-pushed
the
bg_fix_gain_formula
branch
from
7d1dbbe to
8c005b5
Compare
Contributor
Author
|
@tompollard , I've added tests of the gain calculation for when the baseline exceeds the boundary. For each boundary (
|
tompollard
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out by @tcpan in #515 there was a mistake in one of the formula's for calculating ADC gain. The calculation needs to compute the digital range first before mapping the physical range.